added clear_persistent_cache and minor update to persistent caching#440
added clear_persistent_cache and minor update to persistent caching#440salmanulhaq wants to merge 2 commits intoboostorg:masterfrom
Conversation
There was a problem hiding this comment.
Instead of copying these lines, could you just call detail::appdata_path() directly?
|
Also, could you open a pull request against the |
There was a problem hiding this comment.
I think this could be a static method (so users can just call program_cache::clear_persistent_cache() directly without having to get/create a program_cache object).
|
Regarding @keryell's note: one possible solution is to make detail::sha1 hash;
hash(source);
hash(device_name);
hash(compiler_version);
load_program_binary(hash, context); |
|
Yes you are right, since boost/uuid/sha1.hpp has already the right interface. So there is no need to have a Merkle's tree approach that would create several sha1 intermediate objects. |
Added
clear_persistent_cache()inprogram_cache.hppwhich removes.boost_computedirectory.Minor update to persistent caching: instead of computing sha1 hash of just program source, I've also added compiler options and selected device's name so if anything changes, program would be built again.