Skip to content

improve path component usage#490

Open
lgl017temp wants to merge 1 commit intobombshell-dev:mainfrom
lgl017temp:main
Open

improve path component usage#490
lgl017temp wants to merge 1 commit intobombshell-dev:mainfrom
lgl017temp:main

Conversation

@lgl017temp
Copy link

improve path component
1.tab can input selected value
2.put current dict into options
3.allow not exists

To minimize changes, hidden internal API _clearUserInput and _setUserInput was used; a refactoring is recommended.

1.tab can input selected value
2.put current dict into options
3.allow not exists
@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2026

⚠️ No Changeset found

Latest commit: a91ce5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@43081j
Copy link
Collaborator

43081j commented Mar 18, 2026

i think these need more discussion before a PR.

as far as I understand, this is what you've added:

  • exists is a way to allow the user to enter paths which don't exist
  • you can now press tab to append the selected path to the user input, and continue typing
  • add the current user input to the list of results (? not sure why)

but already these are 3 distinct changes which each need to be discussed before we decide if to do them or not.

@lgl017temp
Copy link
Author

lgl017temp commented Mar 19, 2026

i think these need more discussion before a PR.

as far as I understand, this is what you've added:

  • exists is a way to allow the user to enter paths which don't exist
  • you can now press tab to append the selected path to the user input, and continue typing
  • add the current user input to the list of results (? not sure why)

but already these are 3 distinct changes which each need to be discussed before we decide if to do them or not.

  1. Sometime I need select a output path, it may be not exists, I want accept a don't exist dir then call mkdir, better than I create it in explore manually.
  2. When I want into a dir, I must input full name manually. So I want provide a quickly way, like terminal.
  3. [Bug] path directory cant direct select default value #477 At first I just want fix it, then you fix it too. But when I test it, I found you not use sep, it cause not list sub dir when ends with "\". And When combined with the second point, i need add "\" manually. So I keep my solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants