feat: replace HashMap with HashTable for WeakMap#49
Open
shruti2522 wants to merge 1 commit intoboa-dev:mainfrom
Open
feat: replace HashMap with HashTable for WeakMap#49shruti2522 wants to merge 1 commit intoboa-dev:mainfrom
shruti2522 wants to merge 1 commit intoboa-dev:mainfrom
Conversation
nekevss
requested changes
Mar 13, 2026
Member
nekevss
left a comment
There was a problem hiding this comment.
Nice! Pretty big fan of the change.
Can you add a unit test for what happens when somebody tries to insert a Gc<K> for the key on two entries into a WeakMap? Do we handle that correctly?
Mostly I'm skeptical about whether key_addr is actually unique ... so we should test it! 😄
ef94d60 to
5037d9e
Compare
6bb2be1 to
942ef82
Compare
Contributor
Author
|
added three new tests to verify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #13, HashTable is a better approach for our WeakMap
HashTable<(usize,Ptr)>stores address once, whileHashMap<usize, Ptr>stores it twiceHashTable::insert_uniqueavoids the lookupHashMap::insertalways performs.HashTable::find_entryreturns an OccupiedEntry so.remove()extracts the value at that same slot without a second lookup.HashTable::retain(|&mut T|)operates on the entry tuple directly avoiding separate key/value refs