no redundant allocation in text decoder via ArrayBuffer::data()#4670
Merged
jedel1043 merged 4 commits intoboa-dev:mainfrom Feb 22, 2026
Merged
no redundant allocation in text decoder via ArrayBuffer::data()#4670jedel1043 merged 4 commits intoboa-dev:mainfrom
ArrayBuffer::data()#4670jedel1043 merged 4 commits intoboa-dev:mainfrom
Conversation
Test262 conformance changes
|
Contributor
Author
|
Just saw the work in #4650 , #4637, #4631 that all target basically the same area for different issues. And all of them still use the allocating version. |
jedel1043
approved these changes
Feb 22, 2026
Member
jedel1043
left a comment
jedel1043
left a comment
There was a problem hiding this comment.
Thank you for the contribution! Everything looks good, I just had a suggestion for the detached error message.
Member
|
I'll merge this first. #4631 needs another review pass. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4670 +/- ##
==========================================
+ Coverage 47.24% 56.58% +9.33%
==========================================
Files 476 548 +72
Lines 46892 60066 +13174
==========================================
+ Hits 22154 33988 +11834
- Misses 24738 26078 +1340 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhuzhu81998
changed the title
ArrayBuffer::data()ArrayBuffer::data()
jedel1043
added
performance
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 28, 2026
…4763) Closes #4615 . Started because #4637 was closed without merging by the author while it had conflicts due to changes on the main branch from #4670 (let me know in case it was not intended to be closed). Compared to previous PRs on this matter including #4637, this PR avoids allocating unnecessarily.
ashddev
pushed a commit
to ashddev/boa
that referenced
this pull request
Mar 2, 2026
…oa-dev#4763) Closes boa-dev#4615 . Started because boa-dev#4637 was closed without merging by the author while it had conflicts due to changes on the main branch from boa-dev#4670 (let me know in case it was not intended to be closed). Compared to previous PRs on this matter including boa-dev#4637, this PR avoids allocating unnecessarily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes #4362 .
Following the suggestion from @HalidOdat in #4358 .
Note that for
Utf16Be, thedecodefunction does in place swapping and thus requires mutability.