feat(bmm): add information-asymmetric adversarial code review#1114
Closed
alexeyv wants to merge 5 commits intobmad-code-org:mainfrom
Closed
feat(bmm): add information-asymmetric adversarial code review#1114alexeyv wants to merge 5 commits intobmad-code-org:mainfrom
alexeyv wants to merge 5 commits intobmad-code-org:mainfrom
Conversation
Collaborator
Author
|
This is not a trivial change. |
5 tasks
alexeyv
force-pushed
the
feature/more-cynical-review
branch
from
817e0bb to
65c93c5
Compare
Enhance code review workflow with a two-phase approach: - Context-aware review (step 3): Uses story knowledge to check implementation - Asymmetric adversarial review (step 4): Cynical reviewer with no story context judges changes purely on technical merit Key additions: - Cynical reviewer persona that expects to find problems - Execution hierarchy: Task tool > CLI fresh context > inline fallback - Findings consolidation with deduplication across both review phases - Improved severity assessment (CRITICAL/HIGH/MEDIUM/LOW) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Adds Step 5 to quick-dev that automatically runs adversarial code review after implementation completes. Captures baseline commit at workflow start and reviews all changes (tracked + newly created files) using a cynical reviewer persona via subagent, CLI fallback, or inline self-review. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
alexeyv
force-pushed
the
feature/more-cynical-review
branch
from
6c7f72d to
642d5f8
Compare
Convert Quick Dev from monolithic (workflow.yaml + instructions.md) to sharded architecture (workflow.md + steps/) to combat "lost in the middle" problem during long implementation sessions. Changes: - Add 6 step files for focused execution (mode-detection, context-gathering, execute, self-check, adversarial-review, resolve-findings) - Add checkpoint handlers for [a] Advanced Elicitation and [p] Party Mode - Create review-adversarial-general.xml as reusable core task - Remove CLI fallback (claude --print) for platform-agnostic design 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Quick Dev is meant to be low-ceremony. Advanced elicitation and party mode add unnecessary complexity - users who need that level of analysis should use tech-spec or full BMad Method instead. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
Author
|
Closing this PR - the quick-dev sharded format changes have already been merged to main, and the Phase 4 code-review workflow refactoring is now being handled in #1248. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code