Fix count_last_minutes midnight wrapping and bloops_per_day timezone#4
Merged
Fix count_last_minutes midnight wrapping and bloops_per_day timezone#4
Conversation
…r bloops_per_day Co-authored-by: DASPRiD <233300+DASPRiD@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix bugs in count_last_minutes and record_bloop
Fix count_last_minutes midnight wrapping and bloops_per_day timezone
Feb 19, 2026
Member
|
@copilot see failing checks. |
Co-authored-by: DASPRiD <233300+DASPRiD@users.noreply.github.com>
Contributor
Author
Fixed in 52364d7 — |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 19, 2026
## [1.10.7](v1.10.6...v1.10.7) (2026-02-19) ### Bug Fixes * fix count_last_minutes midnight wrapping and bloops_per_day timezone ([#4](#4)) ([da4cd06](da4cd06))
|
🎉 This PR is included in version 1.10.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
count_last_minutes: replacenow_minute.wrapping_sub(i) % MINUTES_IN_DAYwith(now_minute + MINUTES_IN_DAY - i) % MINUTES_IN_DAYrecord_bloop: derivelocal_datefrombloop.recorded_at.with_timezone(tz)(same aslocal_hour) instead of UTC datecount_last_minutes_across_midnight: verifies all 3 minutes are counted when window wraps past UTC midnightrecord_bloop_uses_local_timezone_for_bloops_per_day: verifiesbloops_per_dayis keyed by local date for non-UTC timezonecargo fmtformatting issues in new tests (multi-lineassert_eq!, extra blank line)cargo fmtcheck passes💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.