Remove context param from walkback funcs#5722
Conversation
mikesep
force-pushed
the
linux-aarch64
branch
from
9c6f1a6 to
bf8ed56
Compare
|
/runtests |
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
maxtable [core dumped]
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
mikesep
force-pushed
the
linux-aarch64
branch
from
ca29782 to
02aff9a
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
writes_remsql_names [setup failure]
sc_resume_logicalsc_generated
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
silogdel
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql
markhannum
force-pushed
the
linux-aarch64
branch
2 times, most recently
from
8f657fc to
6e6b2ba
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_resume_logicalsc_generated
reco-ddlk-sql
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
truncatesc_offline_generated
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_resume_logicalsc_generated
recover_deadlock
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
osql_cleanup [core dumped]
sc_resume
silogdel
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
skipscan
reco-ddlk-sql
On other platforms, libunwind's unw_context_t is typedef'd to ucontext_t, but that's not the case on Linux+aarch64 (aka ARM). Since no callers of stack_pc_getlist and stack_pc_walkback are passing an existing ucontext_t* as an input parameter, it's simplest to remove this from the interface and leave the platform-specific code in the .c file. Signed-off-by: Mike Seplowitz <mseplowitz@bloomberg.net>
Signed-off-by: Mike Seplowitz <mseplowitz@bloomberg.net>
Signed-off-by: Mike Seplowitz <mseplowitz@bloomberg.net>
Signed-off-by: Mark Hannum <mhannum@bloomberg.net>
markhannum
force-pushed
the
linux-aarch64
branch
from
6e6b2ba to
771af78
Compare
4 participants
On other platforms, libunwind's
unw_context_tis typedef'd toucontext_t, but that's not the case on Linux+aarch64 (aka ARM). Since no callers ofstack_pc_getlistandstack_pc_walkbackare passing an existingucontext_t*as an input parameter, it's simplest to remove this from the interface and leave the platform-specific code in the.cfile.I also removed some
#ifndef _LINUX_SOURCEguards that seemed to have been there from days whenstack_pc_getlistwasn't implemented on Linux, which it now definitely is.