Skip to content

Don't free authdata if parallel SQL children are still using it#5717

Merged
mohitkhullar merged 1 commit intobloomberg:mainfrom
mohitkhullar:dohsql_auth_reset
Feb 23, 2026
Merged

Don't free authdata if parallel SQL children are still using it#5717
mohitkhullar merged 1 commit intobloomberg:mainfrom
mohitkhullar:dohsql_auth_reset

Conversation

@mohitkhullar
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
reco-ddlk-sql
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
sc_downgrade
truncatesc_offline_generated
insert_lots_ssl_generated
insert_lots

@mohitkhullar mohitkhullar force-pushed the dohsql_auth_reset branch 2 times, most recently from 6363635 to 6660d29 Compare February 17, 2026 16:03
dorinhogea
dorinhogea previously approved these changes Feb 17, 2026
Copy link
Copy Markdown
Contributor

@dorinhogea dorinhogea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
truncatesc [setup core dumped]
catchup_idle [setup core dumped]
sirace [setup core dumped]
maxtable [setup core dumped]
cinsert_linearizable [setup core dumped]
socksql_master_swings [setup core dumped]
systable_locking [setup core dumped]
verify_writes [setup core dumped]
sc_force [setup core dumped]
truncatesc_offline_generated [setup core dumped]

Copy link
Copy Markdown
Contributor

@dorinhogea dorinhogea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@dorinhogea dorinhogea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need change

Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
catchup_idle [setup core dumped]
sirace [setup core dumped]
maxtable [setup core dumped]
truncatesc [setup core dumped]
cinsert_linearizable [setup core dumped]
systable_locking [setup core dumped]
verify_writes [setup core dumped]
socksql_master_swings [setup core dumped]
sc_force [setup core dumped]
truncatesc_offline_generated [setup core dumped]

Signed-off-by: mkhullar <mohit.khullar@gmail.com>
Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated

@mohitkhullar
Copy link
Copy Markdown
Contributor Author

/runtests

Copy link
Copy Markdown
Contributor

@dorinhogea dorinhogea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@mohitkhullar
Copy link
Copy Markdown
Contributor Author

Thanks

@mohitkhullar mohitkhullar merged commit 8edf868 into bloomberg:main Feb 23, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants