feat: support multiple-network deployments#152
Open
KatyaRyazantseva wants to merge 2 commits intoblockblaz:mainfrom
Open
feat: support multiple-network deployments#152KatyaRyazantseva wants to merge 2 commits intoblockblaz:mainfrom
KatyaRyazantseva wants to merge 2 commits intoblockblaz:mainfrom
Conversation
ch4r10t33r
reviewed
Apr 7, 2026
Contributor
ch4r10t33r
left a comment
ch4r10t33r
left a comment
There was a problem hiding this comment.
Isn't there a possibility of validator-config file changing between runs? Should we add some validation or checks to ensure, the rsync doesn't produce incorrect copies on the server?
ch4r10t33r
reviewed
Apr 7, 2026
| node_id: '{{ node_name }}' | ||
| instance: '{{ ansible_host }}' | ||
| network: '{{ network_name }}' | ||
| client_type: '{{ node.name.split("_")[0] }}' |
Contributor
There was a problem hiding this comment.
We should always ensure that client names have just one "_" in them. Maybe add this to readme and integration.md?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides the following updates and fixes:
--validatorConfigflag andNETWORK_DIRabsolute path resolution.