fix: atomic clone/restore to prevent mirror directory destruction#222
Merged
alecthomas merged 1 commit intomainfrom Mar 24, 2026
Merged
fix: atomic clone/restore to prevent mirror directory destruction#222alecthomas merged 1 commit intomainfrom
alecthomas merged 1 commit intomainfrom
Conversation
Clone and snapshot restore now operate in a temporary directory and rename into place only on success. Previously, a bogus upstream URL like "https://github.com/" resolved to "state/git-mirrors/github.com" and a failed restore would os.RemoveAll that path, nuking every GitHub mirror on the pod. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alecthomas
force-pushed
the
aat/atomic-clone-restore
branch
from
de77c25 to
a9e5fcf
Compare
alecthomas
changed the title
stuartwdouglas
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clone and snapshot restore now operate in a temporary directory and
rename into place only on success. Previously, a bogus upstream URL
like "https://github.com/" resolved to "state/git-mirrors/github.com"
and a failed restore would os.RemoveAll that path, nuking every GitHub
mirror on the pod.