Add an API to retrieve the amount of free memory in a GPU #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CascadingRadium
requested review from
Likith101,
Thejas-bhat,
abhinavdangeti,
capemox,
Copilot and
maneuvertomars
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new C API function to retrieve the amount of free GPU memory in bytes. The implementation wraps the existing C++ faiss::gpu::getFreeMemory function to expose it to C callers.
- Adds
faiss_get_free_memoryfunction that takes a device ID and returns the free memory via an output parameter - Follows the established pattern for C API wrappers in the codebase
- Uses the CATCH_AND_HANDLE macro for consistent error handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| c_api/gpu/DeviceUtils_c.h | Declares the new faiss_get_free_memory function with proper documentation |
| c_api/gpu/DeviceUtils_c.cpp | Implements the function by wrapping faiss::gpu::getFreeMemory with appropriate error handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
faiss_get_free_memoryAPI that returns the amount of memory available in a GPU in bytes.