Skip to content

Conversation

@CascadingRadium
Copy link
Member

  • If optimization level is not specified, force usage of "generic"

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the incorrect declaration of FAISS_OPT_LEVEL in the CMake configuration. Previously, it was defined using option() which is meant for boolean values, but it should accept string values for different optimization levels (generic, avx2, avx512, etc.). The fix replaces the option() with a proper conditional string cache variable.

  • Changed FAISS_OPT_LEVEL from an option() to a CACHE STRING variable
  • Added conditional check to only set the variable if not already defined
  • Duplicated the comment line explaining valid values

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants