MB-65860: Added support for file callbacks#72
Closed
Conversation
Likith101
requested review from
CascadingRadium,
Thejas-bhat,
abhinavdangeti,
capemox and
maneuvertomars
Likith101
force-pushed
the
fileCallbacks
branch
from
196628c to
a1964be
Compare
Likith101
force-pushed
the
fileCallbacks
branch
from
a1964be to
b32e7a0
Compare
abhinavdangeti
requested changes
Feb 18, 2026
Likith101
force-pushed
the
fileCallbacks
branch
from
b32e7a0 to
e8f1ee1
Compare
Member
abhinavdangeti
left a comment
abhinavdangeti
left a comment
There was a problem hiding this comment.
I think we can drop this change and declare this in bleve - as it seems the only place where you use this.
Member
|
@Likith101 do we need this change? It seems bleve is the only user for this interface - declare locally .. which already seem to have here - https://github.com/blevesearch/bleve/pull/2209/changes#diff-88ca3a9cf22d6ccb697576f30666f3c855089f0403a5709f05ae6067fe56c66eR392 |
capemox
reviewed
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.