Skip to content

Reference Desktop Native Rust deps install scripts#791

Merged
neuronull merged 4 commits intomainfrom
dn/pm-34175/reference-desktop-native-rust-deps-env-script
Apr 16, 2026
Merged

Reference Desktop Native Rust deps install scripts#791
neuronull merged 4 commits intomainfrom
dn/pm-34175/reference-desktop-native-rust-deps-env-script

Conversation

@neuronull
Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-34175

📔 Objective

Reference the new Rust env install script in the DN dependencies section.

I hesitate to put it in the general Tools page, because that is not specific for clients , and the other repos in the project might have different versioning requirements for the cargo binaries or toolchains.

📸 Screenshots

@neuronull neuronull self-assigned this Apr 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

Logo
Checkmarx One – Scan Summary & Detailsbb57c99f-bbd2-4db5-9e46-7e6267944be8

Great job! No new security vulnerabilities introduced in this pull request

@neuronull neuronull marked this pull request as ready for review April 6, 2026 15:23
@neuronull neuronull requested a review from a team as a code owner April 6, 2026 15:23
Comment thread docs/getting-started/clients/desktop/desktop-native/index.mdx Outdated
Copy link
Copy Markdown
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hesitate to put it in the general Tools page, because that is not specific for clients

There is a spot for this: see docs/getting-started/clients/index.md > Requirements heading. That links out to the general Tools page today, but there's no reason that we can't have information directly under that heading. To me this entire Dependencies section could/should be on that page given that it's part of the monorepo tooling.

@neuronull neuronull added the hold do not merge label Apr 8, 2026
@neuronull
Copy link
Copy Markdown
Contributor Author

I hesitate to put it in the general Tools page, because that is not specific for clients

There is a spot for this: see docs/getting-started/clients/index.md > Requirements heading. That links out to the general Tools page today, but there's no reason that we can't have information directly under that heading. To me this entire Dependencies section could/should be on that page given that it's part of the monorepo tooling.

I'm definitely open to alternative locations for the information.

I do think though that the details of the Rust tooling makes sense to be homed in the Desktop Native page, because it's only used in practice there.

What do you think about the following: similar to how clients/index.md Requirements section points to the general tools page, we could also point to the Desktop Native page's Dependencies section ? For example

Before you start:
- Install Node and npm. See the [Tools and Libraries](https://contributing.bitwarden.com/getting-started/tools) page for more information.
- Install the Rust ecosystem dependencies. See the [Destop Native Dependencies](https://contributing.bitwarden.com/getting-started/clients/desktop/desktop-native/#dependencies) for more information.

@eliykat
Copy link
Copy Markdown
Member

eliykat commented Apr 8, 2026

That sounds good to me!

@neuronull neuronull removed the hold do not merge label Apr 15, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 15, 2026

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6075419
Status: ✅  Deploy successful!
Preview URL: https://3451786e.contributing-docs.pages.dev
Branch Preview URL: https://dn-pm-34175-reference-deskto.contributing-docs.pages.dev

View logs

@neuronull neuronull requested review from Hinton and eliykat April 15, 2026 14:48
Copy link
Copy Markdown
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all these changes to improve our DX!

@neuronull neuronull changed the title Reference DN Rust deps env install script Reference Desktop Native Rust deps install scripts Apr 16, 2026
@neuronull neuronull merged commit a51fbd7 into main Apr 16, 2026
11 of 12 checks passed
@neuronull neuronull deleted the dn/pm-34175/reference-desktop-native-rust-deps-env-script branch April 16, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants