[PM-31835] feat: add generator copy password field on send by aj-rosado · Pull Request #6508 · bitwarden/android

aj-rosado · 2026-02-10T15:27:04Z

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-31835

📔 Objective

Add copy and generator button to the password field on the new send's password AuthType

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

…ield

…835/add-generator-copy-password-field-on-send

github-actions · 2026-02-10T15:33:44Z

Checkmarx One – Scan Summary & Details – deef21eb-484b-42f5-a638-aa7858833e30

Great job! No new security vulnerabilities introduced in this pull request

pamperer562580892423 · 2026-02-10T15:46:46Z

Sorry, nosy user alert. But as I tracked this, I think there already was a fix for this: #6435 (PS: or maybe that was on a component that now gets replaced?!)

But as this #6505 just was reported, it seems to miss the usual "Check password for data breaches" button directly below / attached to that password field. (BTW, like also in your screenshot @aj-rosado)

codecov · 2026-02-10T16:06:56Z

Codecov Report

❌ Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.42%. Comparing base (1a69362) to head (01518d2).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
...d/addedit/components/AddEditSendAuthTypeChooser.kt	96.66%	0 Missing and 1 partial ⚠️
...re/send/addedit/util/AddEditSendStateExtensions.kt	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6508      +/-   ##
==========================================
+ Coverage   86.37%   86.42%   +0.05%     
==========================================
  Files         799      798       -1     
  Lines       56949    56954       +5     
  Branches     8253     8261       +8     
==========================================
+ Hits        49191    49224      +33     
+ Misses       4892     4861      -31     
- Partials     2866     2869       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

aj-rosado · 2026-02-11T17:20:42Z

Sorry, nosy user alert. But as I tracked this, I think there already was a fix for this: #6435 (PS: or maybe that was on a component that now gets replaced?!)

But as this #6505 just was reported, it seems to miss the usual "Check password for data breaches" button directly below / attached to that password field. (BTW, like also in your screenshot @aj-rosado)

That component is being replaced, this change is to add that same buttons on the new component.
Thank you for being aware and raising this 👍

This reverts commit b3053e4.

…835/add-generator-copy-password-field-on-send # Conflicts: # app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendContent.kt # app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/components/AddEditSendAuthTypeChooser.kt # app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendScreenTest.kt

…n-send # Conflicts: # app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendContent.kt # app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendViewModel.kt # app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/components/AddEditSendAuthTypeChooser.kt # app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/util/AddEditSendStateExtensions.kt # app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendScreenTest.kt

...n/com/x8bit/bitwarden/ui/tools/feature/send/addedit/components/AddEditSendAuthTypeChooser.kt

…n-send

...n/com/x8bit/bitwarden/ui/tools/feature/send/addedit/components/AddEditSendAuthTypeChooser.kt

david-livefront · 2026-02-19T17:11:48Z

...n/com/x8bit/bitwarden/ui/tools/feature/send/addedit/components/AddEditSendAuthTypeChooser.kt

+    onPasswordCopyClick: (String) -> Unit,
    password: String,
    isEnabled: Boolean,
+    isSendsRestrictedByPolicy: Boolean,


david-livefront · 2026-02-19T17:12:09Z

...n/com/x8bit/bitwarden/ui/tools/feature/send/addedit/components/AddEditSendAuthTypeChooser.kt

    }
+
+    if (shouldShowDialog) {
+        BitwardenTwoButtonDialog(


app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendContent.kt

david-livefront · 2026-02-19T17:47:38Z

app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendContent.kt

 private fun AddEditSendOptions(
    state: AddEditSendState.ViewState.Content,
-    sendRestrictionPolicy: Boolean,
+    isSendsRestrictedByPolicy: Boolean,


aj-rosado added 5 commits February 6, 2026 17:34

Added new UI for the Email verification on sends

b6b7002

Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth

5dd79bf

Added copy and generator option to the new AuthTypeChooser password f…

2606d6b

…ield

Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth

bc3b881

Merge branch 'PM-31614/update-add-edit-send-ui-email-auth' into PM-31…

042a104

…835/add-generator-copy-password-field-on-send

aj-rosado requested review from a team and david-livefront as code owners February 10, 2026 15:27

github-actions bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature Change Type - Feature Development labels Feb 10, 2026

aj-rosado changed the base branch from main to PM-31614/update-add-edit-send-ui-email-auth February 10, 2026 18:52

pamperer562580892423 mentioned this pull request Feb 11, 2026

PM-31202 implmeneted password modal menu bitwarden/clients#18829

Open

aj-rosado added 3 commits February 11, 2026 16:04

addressed PR comments

107ac9f

Addressed missing ImmutableList calls and fixed tests

9b0b6af

Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth

c91306b

aj-rosado added 7 commits February 11, 2026 19:26

fixed SyncServiceTest

b3053e4

Revert "fixed SyncServiceTest"

c813498

This reverts commit b3053e4.

Changed SendAuthType's SupportingTextRes property to Text

8917a9f

Add SendAuth class that holds data related to send authentication

daed6db

Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth

234e7a5

Using AuthEmail on handlers and improved code

4148769

github-actions bot removed the app:authenticator Bitwarden Authenticator app context label Feb 13, 2026

Base automatically changed from PM-31614/update-add-edit-send-ui-email-auth to main February 13, 2026 23:01

aj-rosado added 2 commits February 19, 2026 12:29

Remove extra dialog content

0da2655