Buy/Sell/Swap: Ref - external services prefetch data#2116
Merged
JohnathanWhite merged 4 commits intobitpay:developfrom Apr 9, 2026
Merged
Buy/Sell/Swap: Ref - external services prefetch data#2116JohnathanWhite merged 4 commits intobitpay:developfrom
JohnathanWhite merged 4 commits intobitpay:developfrom
Conversation
Gamboster
changed the title
JohnathanWhite
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
I refactored the prefetch of externalServices (config and swap supported currencies) to avoid using Redux during app initialization, thus reducing potential UI freezes during data saving.
The cache is now modular-level and remains in memory while the session is active.
I refactored the getExternalServicesConfig to run only once and then reuse it in buy/sell/swap.
I removed the ongoing process from Buy/Sell (it had already been removed from Swap) and replaced it with spinners/skeletons from the view, in an attempt to reduce the time it takes for the user to interact with these features.
Fix: Accessing Buy/Sell from wallet details now correctly selects the wallet from which the user is accessing the feature.