Update Downloader interface to use suspend function#216
Merged
Conversation
- Add KDoc comments for Downloader interface and download method - Change download function to suspend for coroutine support
- Update `fromVCard`, `toContact`, and `getPhotoBytes` in `ContactReader` to suspend functions - Update `fromReader` in `Contact` to suspend function - Add `kotlinx-coroutines-test` dependency for testing - Wrap test methods in `runTest` for coroutine support
…nTest` for coroutine support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
Downloaderinterface to use a suspend function for coroutine support. It also adds KDoc comments for the interface and itsdownloadmethod.Preparation for https://github.com/bitfireAT/davx5/issues/827 / bitfireAT/davx5-ose#2004
Changes:
downloadfunction to be a suspend functionDownloaderinterface anddownloadmethod