Apply pattern matching for instanceof across codebase#435
Merged
ChristianHoesel merged 2 commits intomasterfrom Nov 18, 2025
Merged
Apply pattern matching for instanceof across codebase#435ChristianHoesel merged 2 commits intomasterfrom
ChristianHoesel merged 2 commits intomasterfrom
Conversation
Co-authored-by: ChristianHoesel <4498707+ChristianHoesel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update code to Java 17 and use language features
Apply pattern matching for instanceof across codebase
Nov 18, 2025
upeuker
reviewed
Nov 18, 2025
Member
upeuker
left a comment
There was a problem hiding this comment.
Dafür hätte es nun wirklich keine KI gebraucht :)
ChristianHoesel
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codebase targets Java 17 but wasn't fully utilizing its language features. Applied pattern matching for instanceof (JEP 394) to eliminate redundant casts.
Changes
Configuration.javaandTreeProperties.java: String key checks instringPropertyNames()RemoteTools.java: SocketException cause check in exception handlerSubMonitor.java: SubMonitor type check inconvert()optimization pathExample
Before:
After:
Other Java 17 Features Evaluated
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
www.puppycrawl.com/opt/hostedtoolcache/CodeQL/2.23.3/x64/codeql/tools/linux64/java/bin/java -jar /opt/hostedtoolcache/CodeQL/2.23.3/x64/codeql/xml/tools/xml-extractor.jar --fileList=/home/REDACTED/work/com.bitctrl/.codeql-scratch/dbs/java/working/files-to-index8986416209424227427.list --sourceArchiveDir=/home/REDACTED/work/com.bitctrl/.codeql-scratch/dbs/java/src --outputDir=/home/REDACTED/work/com.bitctrl/.codeql-scratch/dbs/java/trap/java(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.