feat: expose detailed try_finalize_psbt outcomes#433
Open
reez wants to merge 1 commit intobitcoindevkit:masterfrom
Open
feat: expose detailed try_finalize_psbt outcomes#433reez wants to merge 1 commit intobitcoindevkit:masterfrom
reez wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #433 +/- ##
==========================================
+ Coverage 80.04% 80.13% +0.09%
==========================================
Files 24 24
Lines 5336 5367 +31
Branches 242 242
==========================================
+ Hits 4271 4301 +30
- Misses 987 989 +2
+ Partials 78 77 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c65f534 to
e046adc
Compare
Author
|
Updated per some good feedback from mammal |
f15d651 to
f3fb2a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First step for #73, following ValuedMammal's suggestion.
This PR keeps the scope to PSBT finalization only:
try_finalize_psbtwhich returnsFinalizePsbtResultFinalizePsbtInputResultNotes to the reviewers
This is now additive rather than breaking:
Wallet::finalize_psbtstill returnsboolIntentionally not included here:
Wallet::signto return a richer result typeChangelog notice
Wallet::try_finalize_psbt, which returnsFinalizePsbtResultand exposes per-input finalization outcomes while preserving the existingWallet::finalize_psbtAPI.Checklists
All Submissions:
just pbefore pushingNew Features: