Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #360 +/- ##
==========================================
- Coverage 79.17% 79.01% -0.17%
==========================================
Files 24 24
Lines 5311 5298 -13
Branches 242 244 +2
==========================================
- Hits 4205 4186 -19
- Misses 1029 1035 +6
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ValuedMammal
force-pushed
the
deps/chain_0_24_0
branch
from
fdd484b to
5bdacc9
Compare
ValuedMammal
changed the title
bdk_chain to latestbdk_chain to latest (b4c8c6a1)
ValuedMammal
force-pushed
the
deps/chain_0_24_0
branch
2 times, most recently
from
feb8814 to
d469e63
Compare
ValuedMammal
changed the title
bdk_chain to latest (b4c8c6a1)bdk_chain to latest (b45ecb9b)
ValuedMammal
force-pushed
the
deps/chain_0_24_0
branch
3 times, most recently
from
045ac47 to
43a7ffb
Compare
Update dependencies: chain core bitcoind_rpc -> 0.22.0 electrum esplora file_store -> 0.22.0 Changes: - Update usage of `LocalChain` and `CheckPoint` which are now generic. - Change structure of `WalletTx` (alias for `CanonicalTx`). - Introduce `Wallet::canonical_view`. - Update `Wallet::balance` with re-defined trust predicate. - Updated docs for `apply_update` to include an Errors section and a note about the canonical view. - Changed `insert_txout`, `apply_evicted_txs` to internally use `apply_update` as a way to centralize the update logic when it comes to adding transaction data to the wallet. - `apply_unconfirmed_txs` now calls `self.update_canonical_view` internally.
ValuedMammal
force-pushed
the
deps/chain_0_24_0
branch
from
43a7ffb to
7c6a87e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently in draft, the purpose of this PR is to test the wallet crate using the latest version of
bdk. This branch can be updated to depend on version0.24.0ofbdk_chainwhen that is released.Notes to the reviewers
Changelog notice
Checklists
All Submissions:
New Features:
Bugfixes: