feat: public key generation from descriptors

[sdmg15]

Description

This PR as a new function to the wallet API public_key_at_index(keychain, index) which returns the public key found at the specified index. It closes #209

Notes to the reviewers

I explicitly matched all arms branches of the Descriptor<DefiniteDescriptorKey> so that if a new type is added in the future it signals there is a need to update this function too.

Changelog notice

• Add a helper function public_key_at_index(keychain, index) which returns the public key found at the specified index.

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran just p before pushing

New Features:

• I've added tests for the new feature
• I've added docs for the new feature

[codecov]

Codecov Report

❌ Patch coverage is 88.37209% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.26%. Comparing base (bec219a) to head (7ac497f).
⚠️ Report is 7 commits behind head on master.

Files with missing lines	Patch %	Lines
src/wallet/mod.rs	88.37%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
+ Coverage   85.24%   85.26%   +0.01%     
==========================================
  Files          23       23              
  Lines        8230     8273      +43     
==========================================
+ Hits         7016     7054      +38     
- Misses       1214     1219       +5     

Flag	Coverage Δ
rust	85.26% <88.37%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[AdamuAbba]

tACK 7ac497f

Ran the test locally and it was successful.

[AdamuAbba]

minor typo in function name k in public

Suggested change

	fn test_generate_publick_keys() {
	fn test_generate_public_keys() {

[ValuedMammal]

Since it can be done using rust-miniscript I don't think it's a high priority. Out of curiosity are you sure there's no way to return a public key (or keys) from a Bare, Sh, or Wsh? or is there a reason why that's not desirable?

[sdmg15]

Since it can be done using rust-miniscript I don't think it's a high priority. Out of curiosity are you sure there's no way to return a public key (or keys) from a Bare, Sh, or Wsh? or is there a reason why that's not desirable?

I'm happy to review the API if we want to return multiple public keys. The initial thought was returning only a single one. For wsh, sh to get the keys should require to parse the raw miniscript looking for pk, pkh no?