wip,draft: Add async support to persist_test_utils#343
wip,draft: Add async support to persist_test_utils#343ValuedMammal wants to merge 3 commits intobitcoindevkit:masterfrom
persist_test_utils#343Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #343 +/- ##
=======================================
Coverage 79.17% 79.17%
=======================================
Files 24 24
Lines 5311 5311
Branches 242 242
=======================================
Hits 4205 4205
Misses 1029 1029
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ValuedMammal
force-pushed
the
feat/persist_test_utils_async
branch
2 times, most recently
from
15149b5 to
bf0057f
Compare
| pub fn persist_multiple_wallet_changesets<F, P>(create_stores: F) -> Result<(), PersistError> | ||
| where | ||
| F: Fn() -> Result<(P, P), P::Error>, | ||
| P: WalletPersister, | ||
| P::Error: StdErr + 'static, | ||
| { |
There was a problem hiding this comment.
@110CodingP I changed this by removing the &Path arg from the create_stores Fn, which means this function is no longer in control of the path in which the stores are created. After thinking about it I'm not sure this is a feature that needs to be tested. Any thought about whether to keep or improve it somehow?
There was a problem hiding this comment.
I added this function just because we had a test in bdk_redb that checks if two different wallets can be persisted in the same file. So this test just differentiates between these two kinds of backends. I am not very confident about whether this is worth keeping since it might be just bdk_redb that can use it. Will think more about the improvement part.
Sorry for the late reply 🙏 , didn't check the notifications carefully...
ValuedMammal
force-pushed
the
feat/persist_test_utils_async
branch
from
bf0057f to
7e53c18
Compare
Changed the definition of `persist_*` functions to take a `create_store` Fn (and no path) as the caller may want more control of the path to the database file. - deps: Make tempfile, anyhow dev-dependencies
ValuedMammal
force-pushed
the
feat/persist_test_utils_async
branch
from
7e53c18 to
8be4c86
Compare
2 participants
Description
Initial work on expanding
persist_test_utilsmodule by adding a functionpersist_wallet_changeset_asyncto be used for testing anAsyncWalletPersisterimplementation.Changelog notice
Added
persist_wallet_changeset_asyncto persistence test suite for testing anAsyncWalletPersister.Checklists
All Submissions:
New Features: