Bump bitcoin dependency requirement to v0.32.6 to reflect used API
#266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Starting with commit `f6fd9853e`, `bdk_wallet` makes use of
`bitcoin::key::TweakedKeyPair::to_keypair` which was introduced with
v0.32.6. Here, we adjust the minimum API requirement in `Cargo.toml`, as
BDK 2.0.0 builds could otherwise fail with:
```
error[E0599]: no method named `to_keypair` found for struct `TweakedKeypair` in the current scope
--> /home/tnull/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bdk_wallet-2.0.0/src/wallet/signer.rs:580:14
|
578 | None => keypair
| _________________-
579 | | .tap_tweak(secp, psbt_input.tap_merkle_root)
580 | | .to_keypair(),
| | -^^^^^^^^^^ method not found in `TweakedKeypair`
| |_____________|
|
For more information about this error, try `rustc --explain E0599`.
```
ValuedMammal
force-pushed
the
2025-06-bump-bitcoin-version-to-unbreak-semver
branch
from
c9c8806 to
af792ea
Compare
Collaborator
|
reACK af792ea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting with commit
f6fd9853e,bdk_walletmakes use ofbitcoin::key::TweakedKeyPair::to_keypairwhich was introduced with v0.32.6. Here, we adjust the minimum API requirement inCargo.toml, as BDK 2.0.0 builds could otherwise fail with: