Add wasm compatible database using gloo_storage::LocalStorage#789
Closed
benthecarman wants to merge 1 commit intobitcoindevkit:masterfrom
Closed
Add wasm compatible database using gloo_storage::LocalStorage#789benthecarman wants to merge 1 commit intobitcoindevkit:masterfrom
benthecarman wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
24 tasks
Member
|
@futurepaul sorry for the delay in commenting on this PR, it looks like a great addition but right now we're trying to avoid adding new features like this to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #450
Adds a new database type for wasm builds. This is basically copied from MutinyWallet/mutiny-node#5
Notes to the reviewers
I am not sure if the tests are working correctly, couldnt figure out how to properly run with them without
wasm-packChecklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: