Use Esplora's get_block_hash() method#783
Closed
tnull wants to merge 1 commit intobitcoindevkit:masterfrom
Closed
Conversation
Contributor
|
Seems like this needs a new release of |
Contributor
Author
Correct, as noted in the description. Feel free to add a corresponding tag. |
Member
|
The new esplora-client 0.2 was released today and will get updated in the upcoming bdk 0.24.0 milestone via #770. Since this PR doesn't look like an urgent change I added it to the 0.25.0 bdk milestone. |
e9024cb to
c0e9ca3
Compare
Contributor
Author
Member
|
Sorry I missed this PR and did the same change in #770 (your deprecation notice was very helpful!). I'm going to close this one since it won't be needed anymore, sorry for not noticing it before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes use of the recently added
get_block_hash()API method of the Esplora client.Previously, we retrieved the entire header to extract the
BlockHash. Funnily enough, the header was internally retrieved through a combination of getting hash by height and then getting the header by hash.Notes to the reviewers
This is currently blocked on the next release of
rust-esplora-client.Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: