fix(chain): prevent merge_chains from replacing the genesis block#2174
Open
tnull wants to merge 1 commit intobitcoindevkit:release/chain-0.23.xfrom
Open
fix(chain): prevent merge_chains from replacing the genesis block#2174tnull wants to merge 1 commit intobitcoindevkit:release/chain-0.23.xfrom
merge_chains from replacing the genesis block#2174tnull wants to merge 1 commit intobitcoindevkit:release/chain-0.23.xfrom
Conversation
Other code paths (`disconnect_from`, `CheckPoint::insert`) already protect height 0 from modification, but `merge_chains` allowed an update chain with a different genesis hash to silently replace the wallet's existing genesis block. Return `CannotConnectError` when the update attempts to change the block hash at height 0. Co-Authored-By: HAL 9000 Signed-off-by: Elias Rohrer <dev@tnull.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Other code paths (
disconnect_from,CheckPoint::insert) already protect height 0 from modification, butmerge_chainsallowed an update chain with a different genesis hash to silently replace the wallet's existing genesis block. ReturnCannotConnectErrorwhen the update attempts to change the block hash at height 0.Co-Authored-By: HAL 9000
Checklists
All Submissions:
Bugfixes: