Skip to content

fix(chain): forward confirmation_height_upper_bound in Anchor implementation for &A#2120

Open
evanlinjin wants to merge 1 commit intobitcoindevkit:masterfrom
evanlinjin:fix/forward-confirmation-height-upper-bound-anchor
Open

fix(chain): forward confirmation_height_upper_bound in Anchor implementation for &A#2120
evanlinjin wants to merge 1 commit intobitcoindevkit:masterfrom
evanlinjin:fix/forward-confirmation-height-upper-bound-anchor

Conversation

@evanlinjin
Copy link
Member

Description

The blanket Anchor impl for &A was missing the confirmation_height_upper_bound method, causing it to fall back to the default implementation instead of delegating to the inner type.

Changelog notice

Fixed:

- The `Anchor::confirmation_height_upper_bound` impl was missing for `&A`, causing it to fallback to the default impl.

Checklists

All Submissions:

Bugfixes:

* [ ] This pull request breaks the existing API
* [ ] I've added tests to reproduce the issue which are now passing
* [ ] I'm linking the issue being fixed by this PR

…l for `&A`

The blanket `Anchor` impl for `&A` was missing the
`confirmation_height_upper_bound` method, causing it to fall back to
the default implementation instead of delegating to the inner type.
@evanlinjin evanlinjin added the bug Something isn't working label Feb 14, 2026
@evanlinjin evanlinjin self-assigned this Feb 14, 2026
@oleonardolima oleonardolima added this to the Chain 0.24.0 milestone Feb 20, 2026
@oleonardolima oleonardolima moved this to In Progress in BDK Chain Feb 20, 2026
@oleonardolima oleonardolima self-requested a review February 20, 2026 16:54
Copy link
Contributor

@Dmenec Dmenec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approach ACK

replacing &self with self should fix the Clippy lint that is breaking CI

fn confirmation_height_upper_bound(&self) -> u32 {
    <A as Anchor>::confirmation_height_upper_bound(self)
}

@Serious-Sam-Dev
Copy link

approach ACK, how the comment above says

approach ACK

replacing &self with self should fix the Clippy lint that is breaking CI

fn confirmation_height_upper_bound(&self) -> u32 {
    <A as Anchor>::confirmation_height_upper_bound(self)
}

only change need is to fix the clippy, all another test is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

5 participants