Add sent_and_received_txouts methods to SPK and Keychain TxOut indexes #2081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indexes Implement sent_and_received_txouts methods on SpkTxOutIndex and KeychainTxOutIndex. These methods return actual TxOut structs allowing callers to access complete transaction output information including script pubkeys and values.
notmandatory
force-pushed
the
feat/send_recvd_txouts
branch
from
b927934 to
c1b4c5f
Compare
notmandatory
changed the title
Open
6 tasks
notmandatory
commented
Dec 10, 2025
| /// // Get sent and received txouts for a transaction across all tracked addresses | ||
| /// let (sent_txouts, received_txouts) = index.sent_and_received_txouts(&tx, ..); | ||
| /// | ||
| /// // Display addresses and amounts |
Member
Author
There was a problem hiding this comment.
@tnull would this information be useful for LDKnode when handling the transactions in WalletEvents ?
Contributor
There was a problem hiding this comment.
Ah, yes, that would be very helpful, we just recently got requests to be able to see which address was sent to: lightningdevkit/ldk-node#684
Do you happen to see a way to include the output's index in this API, too? (cf. lightningdevkit/ldk-node#717). Maybe the return type could be (Vec<(usize, TxOut)>, Vec<(usize, TxOut)>), or a similar struct representation?
Member
Author
There was a problem hiding this comment.
Good idea, since the input & output Vecs of Transaction are in the correct order I'm able to return the index info with the TxOuts. See 6ff9f26.
notmandatory
force-pushed
the
feat/send_recvd_txouts
branch
2 times, most recently
from
47a3f66 to
b9aaf05
Compare
Return tuple of (index, TxOut) in sent_and_received_txouts methods to identify which input/output positions the TxOuts correspond to in the original transaction.
notmandatory
force-pushed
the
feat/send_recvd_txouts
branch
from
b9aaf05 to
6ff9f26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement sent_and_received_txouts methods on SpkTxOutIndex and KeychainTxOutIndex. These methods return actual TxOut structs allowing callers to access complete transaction output information including script pubkeys and values.
Notes to the reviewers
This info is useful to users who use the new WalletEvent data in bitcoindevkit/bdk_wallet#319. In particular to determine the addresses and amounts for TxOuts that are sent/spent or have been received in a newly seen or confirmed transaction. See: bdk_wallet#319 comment
If/when this PR is merged I'll make a corresponding one to add a
Wallet::sent_and_received_txoutsmethod.Changelog notice
Added
Checklists
All Submissions:
New Features: