Manually decode form parameters

[bbimber]

Something changed between 25.3 and 25.7 related to HTML encoding of DataRegion PKs. Below is a summary:

• We have a SQL query where the PKs values contain the delimiter string '<>'. There is a client-side form associated with a DataRegion that grabs the PKs from the checked rows using LABKEY.DataRegion.getChecked(), and POSTs them to the server using a vanilla LABKEY.Ajax.request(). That code is here:

BimberLabKeyModules/GenotypeAssays/resources/web/genotypeassays/window/PublishResultsWindow.js

Line 124 in 8a4bd6c

alleleNames: alleleNames,

• I noticed that the PKs as returned by DataRegion.getChecked() are HTML encoded. This is different from 25.3 (more below):

• The controller gets that array of PKs using basic form binding. Prior to 25.7, this never needed to do any server-side HTML decoding. The server-side code is here:

  BimberLabKeyModules/GenotypeAssays/src/org/labkey/genotypeassays/GenotypeAssaysController.java

  Line 133 in 8a4bd6c

  Pair<List<Integer>, List<Integer>> ret = GenotypeAssaysManager.get().cacheAnalyses(getViewContext(), protocol, form.getAlleleNames());

• Those HTML-encoded PKs are passed to a TableSelector, and this fails to find the right rows, since the PKs are encoded:

  BimberLabKeyModules/GenotypeAssays/src/org/labkey/genotypeassays/GenotypeAssaysManager.java

  Line 124 in 8a4bd6c

  TableSelector tsAlignments = new TableSelector(tableAlignments, cols.values(), new SimpleFilter(FieldKey.fromString("key"), Arrays.asList(pks), CompareType.IN), null);

This PR fixes the problem by adding explicit HTML decoding on the server.

To track down what's different from 25.3, I made a list on a 25.3 server where the PK is a string (https://prime.ohsu.edu/list/ONPRC/Core%20Facilities/Genetics%20Core/MHC_Typing/grid.view?listId=7). I added similar values, and we see that on 25.3 the '<>' is not encoded.

Is this a deliberate change in 25.7?