Fix upsert so it processes the matched node#3727
Open
MichaelWest22 wants to merge 1 commit intobigskysoftware:four-devfrom
Open
Fix upsert so it processes the matched node#3727MichaelWest22 wants to merge 1 commit intobigskysoftware:four-devfrom
MichaelWest22 wants to merge 1 commit intobigskysoftware:four-devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
when upsert matches on an id'ed node it uses outerHTML replacement which creates a new node and this prevents the updated node getting processed by htmx which prevents any nodes from hosting active htmx controls. only newContent children nodes are processed after the custom swap happens unless you explicitly return an array of nodes to process and upsert just returns true and so the original unused child node is processed but not the newly created one via outerHTML assignment.
To fix this we just need to use replaceWith instead which then uses the newContent node correctly.
Corresponding issue:
#3725
Testing
Added test to reproduce the issue
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded