Skip to content

Widened the no_default_pages option to work also with the logout-page #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hertell wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Widened the no_default_pages option to work also with the logout-page #12

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
37551aa
Honours no_default_pages settings also for logout-page
hertell Dec 18, 2012
1e01ad0
Revert "Honours no_default_pages settings also for logout-page"
hertell Dec 18, 2012
5a1f4d2
Revert "Revert "Honours no_default_pages settings also for logout-page""
hertell Dec 18, 2012
3d9cc63
Revert "Honours no_default_pages settings also for logout-page"
hertell Dec 18, 2012
9312e63
Honours no_default_pages setting also for logoutpage
hertell Dec 18, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions lib/Dancer/Plugin/Auth/Extensible.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,17 +471,18 @@ post $loginpage => sub {
};

# ... and logging out.
any ['get','post'] => $logoutpage => sub {
session->destroy;
if (params->{return_url}) {
redirect params->{return_url};
} else {
# TODO: perhaps make this more configurable, perhaps by attempting to
# render a template first.
return "OK, logged out successfully.";
}
};

if (!$settings->{no_default_pages}) {
any ['get','post'] => $logoutpage => sub {
session->destroy;
if (params->{return_url}) {
redirect params->{return_url};
} else {
# TODO: perhaps make this more configurable, perhaps by attempting to
# render a template first.
return "OK, logged out successfully.";
}
};
}
sub _default_permission_denied_page {
return <<PAGE
<h1>Permission Denied</h1>
Expand Down