feat(layout): hide presentation according to layout.xml new events#331
Open
germanocaumo wants to merge 3 commits intodevelopfrom
Open
feat(layout): hide presentation according to layout.xml new events#331germanocaumo wants to merge 3 commits intodevelopfrom
germanocaumo wants to merge 3 commits intodevelopfrom
Conversation
This adds support to the new event saying when the presenter minimized the presentation. When found it: - Hides presentation (and thumbnails) completely - Make the webcams occupy the main area - Expands chat/notes to full left side (like it is when single content)
…entation Fixes some bugs mainly when seeking into/out minimized presentation.
fixes duplicated presentation/screenshare thumbnails in some cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support to the new event saying when the presenter minimized the presentation (added in bigbluebutton/bigbluebutton#23924). When found it:
Playback.mp4
This PR should be merged and tagged togeter with bigbluebutton/bigbluebutton#23924 so they are kept in sync and don't generate artificacts of screenshare as content in thumbnails.