-
Notifications
You must be signed in to change notification settings - Fork 51
move thermorawfileparser from local to bigbio nf-core #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
nf-core lint tool doesn't support other repo modules. So should we ignore this lint for module json? |
|
@daichengxin as far as I understand the remote modules is done for that and it could work, I think it could be because the prettier you applied in here 32cdbc4, is different from the sha we have in the main module public. I think this mechanism should work out of the box because is the mechanism nf-core has for private workflows and institutional workflows where not all the modules can be make public. BTW, I was checking how it works for |
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).