fix: Windows spawn EINVAL with paths containing spaces#62
Open
matiassanchez12 wants to merge 1 commit into
Open
fix: Windows spawn EINVAL with paths containing spaces#62matiassanchez12 wants to merge 1 commit into
matiassanchez12 wants to merge 1 commit into
Conversation
| cwd: projectPath, | ||
| env, | ||
| stdio: ["inherit", "pipe", "pipe"], | ||
| shell: true, |
Collaborator
There was a problem hiding this comment.
Enabling shell: true unconditionally makes this fix platform-wide. The Windows command is quoted above, but POSIX paths returned by resolveOpencodeCommand are now passed through /bin/sh unquoted and can still be split if they contain spaces. Please keep direct spawn(command, args, ...) behavior on POSIX and only enable shell mode for Windows, with a regression test for a Windows command path containing spaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Closes #
Type of Change
Changes Made
Testing
npm test)Checklist
Screenshots (if applicable)
Additional Notes
Fixes Windows spawn EINVAL errors when OpenCode is installed in paths with spaces (e.g. C:\Program Files).
Errors fixed: