Skip to content

Simplify test #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdrienVannson merged 1 commit into from
Sep 25, 2025
Merged

Simplify test #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 3 additions & 19 deletions betterproto2/tests/grpc/test_grpclib_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,7 @@ async def test_service_call_lower_level_with_overrides(requires_grpclib, require
import grpclib.metadata
from grpclib.testing import ChannelFor

from tests.outputs.service.service import (
DoThingRequest,
DoThingResponse,
TestStub as ThingServiceClient,
)
from tests.outputs.service.service import DoThingRequest, TestStub as ThingServiceClient

from .thing_service import ThingService

Expand All @@ -170,13 +166,7 @@ async def test_service_call_lower_level_with_overrides(requires_grpclib, require
kwarg_metadata = {"authorization": "12345"}
async with ChannelFor([ThingService(test_hook=_assert_request_meta_received(deadline, metadata))]) as channel:
client = ThingServiceClient(channel, deadline=deadline, metadata=metadata)
response = await client._unary_unary(
"/service.Test/DoThing",
DoThingRequest(THING_TO_DO),
DoThingResponse,
deadline=kwarg_deadline,
metadata=kwarg_metadata,
)
response = await client.do_thing(DoThingRequest(THING_TO_DO), deadline=kwarg_deadline, metadata=kwarg_metadata)
assert response.names == [THING_TO_DO]

# Setting timeout
Expand All @@ -194,13 +184,7 @@ async def test_service_call_lower_level_with_overrides(requires_grpclib, require
]
) as channel:
client = ThingServiceClient(channel, deadline=deadline, metadata=metadata)
response = await client._unary_unary(
"/service.Test/DoThing",
DoThingRequest(THING_TO_DO),
DoThingResponse,
timeout=kwarg_timeout,
metadata=kwarg_metadata,
)
response = await client.do_thing(DoThingRequest(THING_TO_DO), timeout=kwarg_timeout, metadata=kwarg_metadata)
assert response.names == [THING_TO_DO]


Expand Down
Loading