Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion betterproto2/src/betterproto2/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -1270,7 +1270,7 @@ def is_set(self, name: str) -> bool:
:class:`bool`
`True` if field has been set, otherwise `False`.
"""
return self.__getattribute__(name) is not self._get_field_default(name)
return self.__getattribute__(name) != self._get_field_default(name)

@classmethod
def _validate_field_groups(cls, values):
Expand Down
2 changes: 2 additions & 0 deletions betterproto2/tests/test_features.py
Original file line number Diff line number Diff line change
Expand Up @@ -430,8 +430,10 @@ def test_is_set():

assert not MsgE().is_set("bool_field")
assert not MsgE().is_set("int_field")
assert not MsgE().is_set("str_field")
assert MsgE(bool_field=True).is_set("bool_field")
assert MsgE(bool_field=True, int_field=0).is_set("int_field")
assert MsgE(str_field=["a", "b", "c"]).is_set("str_field")


def test_equality_comparison():
Expand Down
1 change: 1 addition & 0 deletions betterproto2_compiler/tests/inputs/features/features.proto
Original file line number Diff line number Diff line change
Expand Up @@ -104,4 +104,5 @@ message MsgD {
message MsgE {
bool bool_field = 1;
optional int32 int_field = 2;
repeated string str_field = 3;
}
Loading