Skip to content
This repository was archived by the owner on Aug 22, 2023. It is now read-only.

fix: TraceableChainActivator type exception without Debugmode#96

Open
AlfoMart wants to merge 1 commit intobestit:masterfrom
AlfoMart:master
Open

fix: TraceableChainActivator type exception without Debugmode#96
AlfoMart wants to merge 1 commit intobestit:masterfrom
AlfoMart:master

Conversation

@AlfoMart
Copy link

@AlfoMart AlfoMart commented May 24, 2022

With update the default class for flagception.activator.chain_activator was set to Flagception\Activator\ChainActivator but within src/Profiler/FeatureDataCollector.php type was still only accepting TraceableChainActivator

@mKnoop mKnoop self-assigned this Aug 10, 2022
@mKnoop mKnoop added the review Issues that are currently checked label Aug 10, 2022
@floplus
Copy link

floplus commented Jul 11, 2023

@wopoczynski @carlosjfernandes what happens if the collect method of the FeatureDataCollector ist called? The getTrace method does not exist. So this won't work.
The collect method would have to check on !instance of TraceableChainActivator and then just return.
Or am i wrong?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@wopoczynski wopoczynski wopoczynski approved these changes

@carlosjfernandes carlosjfernandes carlosjfernandes approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@mKnoop mKnoop

Labels

review Issues that are currently checked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AlfoMart @floplus @wopoczynski @carlosjfernandes @mKnoop