Add option to opt out of text diffing#314
Closed
ViktorQvarfordt wants to merge 1 commit intobenjamine:masterfrom
ViktorQvarfordt:master
Closed
Add option to opt out of text diffing#314ViktorQvarfordt wants to merge 1 commit intobenjamine:masterfrom ViktorQvarfordt:master
ViktorQvarfordt wants to merge 1 commit intobenjamine:masterfrom
ViktorQvarfordt:master
Conversation
Collaborator
|
Thanks for the PR, and apologies for the delay in responding to it! This should be resolved by #352 making text diffs opt-in. Let us know if you have any other issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a new option rather than
minLength: -1or similar to avoid a breaking change to the API, and to rely on explicit parameters rather than implicit behavior.