Allow user to specify a maxLength for character diffing#263
Open
philnova wants to merge 3 commits intobenjamine:masterfrom
Open
Allow user to specify a maxLength for character diffing#263philnova wants to merge 3 commits intobenjamine:masterfrom
philnova wants to merge 3 commits intobenjamine:masterfrom
Conversation
Collaborator
|
Thanks for the PR, and sorry for the delayed response! Do you have an example of "inaccurate results" with text diffing? It seems like the linked issue was primarily confused about text diffs in general which has now been disabled by default in v0.6.0. Let us know if that satisfies the intent of this PR, or if there's anything else we can do to help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users have reported inaccurate results from character diffing with very long strings, e.g. #248. This change would allow users to specify a max length for character diffing.