Use updated CanvasBuilder, revert type checking workaround for verify #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwin-benchling
approved these changes
Nov 19, 2024
damola-benchling
approved these changes
Nov 19, 2024
| # Important! To verify webhooks, we need to pass the body as an unmodified string | ||
| # Flask's request.data is bytes, so decode to string. Passing bytes or JSON won't work | ||
| verify(app_def_id, request.data.decode("utf-8"), request.headers) # type: ignore[arg-type] | ||
| verify(app_def_id, request.data.decode("utf-8"), request.headers) |
damola-benchling
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to Benchling SDK v1.21.1 which fixes the issue with request.headers needing to be a
dict.More info on the SDK update here.