Task migration #276
Draft
JorgeV92 wants to merge 10 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continue the migration of components from
beman.taskintobeman.execution.The main changes are:
beman/execution/task.hppheader so users can refer tobeman::execution::task.beman::execution::detailas part of thebeman.taskmigration.The current branch keeps the task internals directly under
beman::execution::detail. I would appreciate feedback on whether this layout is perfered, or whether the task-specific components should instead be grouped under a nested namespace such asbeman::execution::detail::taskfor better modularization.allocator_support.hppto better align with the allocator model described in P3980R1.The task implementation is organized under
include/beman/execution/detail/task/instead of placing all task internals directly indetail/.Current structure:
include/beman/execution/ ├── execution.hpp ├── functional.hpp ├── stop_token.hpp ├── task.hpp └── detail/ └── task/ ├── allocator_of.hpp ├── completion.hpp ├── error_types_of.hpp ├── handle.hpp ├── poly.hpp ├── promise_env.hpp ├── state_rep.hpp └── stop_source_of.hppall
taskrelated functionality will be added under/task.