feat(core): type checking for mods in withBemMod#463
Open
belozer wants to merge 2 commits intobem:masterfrom
belozer:reuired-mods
Open
feat(core): type checking for mods in withBemMod#463belozer wants to merge 2 commits intobem:masterfrom belozer:reuired-mods
belozer wants to merge 2 commits intobem:masterfrom
belozer:reuired-mods
Conversation
belozer
commented
Aug 9, 2019
| const entity = cn(blockName); | ||
| const isMatched = (key: string) => (props as Dictionary)[key] === mod[key]; | ||
| const isStarMatched = (key: string) => mod[key] === '*' && Boolean((props as Dictionary)[key]); | ||
| const isMatched = (key: string) => (props as Dictionary)[key] === (mod as Dictionary)[key]; |
Member
Author
There was a problem hiding this comment.
Чёт мне не нравится постоянное дублирование props as Dictionary, mod as Dictionary
Это можно "профиксить" так
const _props = props as Dictionary;
const _mod = mod as Dictionary;
yarastqt
reviewed
Aug 9, 2019
belozer
commented
Aug 9, 2019
| it('should add modifier class for matched prop', () => { | ||
| const Enhanced1 = withBemMod<IPresenterProps>(presenter(), { theme: 'normal' })(Presenter); | ||
| const Enhanced2 = withBemMod<IPresenterProps>(presenter(), { view: 'default' })(Enhanced1); | ||
| const Enhanced1 = withBemMod<{theme?: 'normal'}>(presenter(), { theme: 'normal' })(Presenter); |
Member
Author
There was a problem hiding this comment.
Здесь нужны пробелы? <{ theme?: 'normal' }>
belozer
changed the title
belozer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #458