Conversation
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6374 +/- ##
=======================================
Coverage 69.32% 69.32%
=======================================
Files 141 141
Lines 18786 18786
Branches 3060 3060
=======================================
Hits 13024 13024
Misses 5117 5117
Partials 645 645 🚀 New features to boost your workflow:
|
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
8d29812 to
df7db24
Compare
There was a problem hiding this comment.
Pull request overview
PR make symlink tests stop failing on macOS, where temp path can have extra symlink hop (/var -> /private/var). Grug see this fit test suite: compare real target path, not stringy path.
Changes:
- In importer symlink test, compare
resolve()on both sides. - In file move/link test, compare
resolve()on both sides.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/test_importer.py | Make symlink target assertion use resolved real paths on both sides. |
| test/test_files.py | Make link target assertion use resolved real paths on both sides. |
Description
👋🏻 I was trying to set up a local dev environment and noticed a couple of tests were failing. On macOS, temporary files are created under
/var, which is itself a symlink to/private/var. This PR resolves theasserts against temp file paths in tests.To Do
DocumentationChangelog(seems unnecessary for a tests-only fix, but I can add if you'd like)