Skip to content

Fix symlink tests for macOS#6374

Merged
snejus merged 1 commit intobeetbox:masterfrom
faevourite:fix-mac-symlink-tests
Mar 2, 2026
Merged

Fix symlink tests for macOS#6374
snejus merged 1 commit intobeetbox:masterfrom
faevourite:fix-mac-symlink-tests

Conversation

@faevourite
Copy link
Copy Markdown
Contributor

Description

👋🏻 I was trying to set up a local dev environment and noticed a couple of tests were failing. On macOS, temporary files are created under /var, which is itself a symlink to /private/var. This PR resolves the asserts against temp file paths in tests.

To Do

  • Documentation
  • Changelog (seems unnecessary for a tests-only fix, but I can add if you'd like)
  • Tests

@github-actions
Copy link
Copy Markdown

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.32%. Comparing base (d2faa5e) to head (df7db24).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6374   +/-   ##
=======================================
  Coverage   69.32%   69.32%           
=======================================
  Files         141      141           
  Lines       18786    18786           
  Branches     3060     3060           
=======================================
  Hits        13024    13024           
  Misses       5117     5117           
  Partials      645      645           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@faevourite faevourite marked this pull request as ready for review February 17, 2026 01:49
@faevourite faevourite requested a review from a team as a code owner February 17, 2026 01:49
@github-actions
Copy link
Copy Markdown

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

Copy link
Copy Markdown
Member

@snejus snejus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

Copilot AI review requested due to automatic review settings March 2, 2026 09:24
@snejus snejus force-pushed the fix-mac-symlink-tests branch from 8d29812 to df7db24 Compare March 2, 2026 09:24
@snejus snejus enabled auto-merge March 2, 2026 09:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

PR make symlink tests stop failing on macOS, where temp path can have extra symlink hop (/var -> /private/var). Grug see this fit test suite: compare real target path, not stringy path.

Changes:

  • In importer symlink test, compare resolve() on both sides.
  • In file move/link test, compare resolve() on both sides.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/test_importer.py Make symlink target assertion use resolved real paths on both sides.
test/test_files.py Make link target assertion use resolved real paths on both sides.

@snejus snejus merged commit 43a2c69 into beetbox:master Mar 2, 2026
18 checks passed
@faevourite faevourite deleted the fix-mac-symlink-tests branch March 2, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants