Open
Conversation
Prioritise Docker section, as this file is also automatically shown in Docker Hub as an image description. In the future it'd be nice to move Dockerfile to the docker directory. Then we could have Readme specific for Dockerhub. Also, general clean-up of commands and sections and typos.
Author
|
@bbinet Hey, can you check that out? |
bbinet
requested changes
Nov 28, 2016
Owner
bbinet
left a comment
bbinet
left a comment
There was a problem hiding this comment.
Sorry, but I'm not in favor of prioritizing the Docker section and moving it to the top.
But we could add a line at the top, to point docker users to the docker section at the bottom of the file.
README.rst
Outdated
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| The command below will pull the image from the Docker Hub if it's not already downloaded | ||
| and run `Reverse-ssh-manager` in a Docker containter named `rsm`. |
s/containter/container
Author
|
How is it now @bbinet ? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prioritise Docker section, as this file is also automatically shown in Docker Hub as an image description. In the future it'd be nice to move Dockerfile to the docker directory. Then we could have Readme specific for Dockerhub.
Also, general clean-up of commands and sections and typos.