Replace hard-coded podcast icon in in-article promo with dynamic content-type icon logic#13764
Merged
emilysaffron merged 10 commits intolatestfrom Mar 10, 2026
Merged
Conversation
emilysaffron
changed the title
emilysaffron
changed the title
Louis-Matsika
approved these changes
Mar 9, 2026
|
|
||
| export const MIN_SIZE = 939; | ||
| export const MAX_SIZE = 1303; | ||
| export const MAX_SIZE = 1309; |
Contributor
There was a problem hiding this comment.
Hmm this seems to add a decent amount to the bundles, as the svgs are inlined in the code. Could be worth creating a tech ticket to host the SVG's separately so they can be lazy loaded in which will reduce the bundle sizes
HarveyPeachey
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA:
Summary
A lot of services use the inline Podcast Promo to promote whatsapp channels. Amharic promotes youtube. Others have used them in the past to promote various other social channels too.
Examples:
https://www.bbc.com/swahili/articles/cwyk87elk4wo
https://www.bbc.com/amharic/articles/cwy6ndkzp4wo
We should update the icon within the podcast promo to reflect that correctly instead of using the podcast logo for everything.
Code changes
logo logic confirmed with UX and product:
podcast logo for podcasts
youtube logo for youtube
whatsapp logo for whatsapp
using a generic 'communication' svg from https://www.bbc.co.uk/gel/features/iconography for everything else
Testing
Useful Links