Skip to content

Remove rust_binary(out_binary=True) hack. #3891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UebelAndre merged 1 commit into from
Mar 7, 2026
Merged

Remove rust_binary(out_binary=True) hack. #3891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions rust/private/rust.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1176,14 +1176,6 @@ _rust_binary_attrs = {
"""),
allow_single_file = True,
),
"out_binary": attr.bool(
doc = (
"Force a target, regardless of it's `crate_type`, to always mark the " +
"file as executable. This attribute is only used to support wasm targets but is " +
"expected to be removed following a resolution to https://github.com/bazelbuild/rules_rust/issues/771."
),
default = False,
),
"stamp": _stamp_attribute(default_value = -1),
} | _experimental_use_cc_common_link_attrs

Expand Down
11 changes: 1 addition & 10 deletions rust/private/rustc.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1679,11 +1679,7 @@ def rustc_compile_action(
transitive_runfiles.append(dynamic_libraries)
runfiles = runfiles.merge_all(transitive_runfiles)

# TODO: Remove after some resolution to
# https://github.com/bazelbuild/rules_rust/issues/771
out_binary = getattr(attr, "out_binary", False)

executable = crate_info.output if crate_info.type == "bin" or crate_info.is_test or out_binary else None
executable = crate_info.output if crate_info.type == "bin" or crate_info.is_test else None

instrumented_files_kwargs = {
"dependency_attributes": ["deps", "crate"],
Expand Down Expand Up @@ -1895,11 +1891,6 @@ def establish_cc_info(ctx, attr, crate_info, toolchain, cc_toolchain, feature_co
if crate_info.type not in ("staticlib", "cdylib", "rlib", "lib"):
return []

# TODO: Remove after some resolution to
# https://github.com/bazelbuild/rules_rust/issues/771
if getattr(attr, "out_binary", False):
return []

dot_a = None
library_to_link = None

Expand Down