apply https://github.com/bazelbuild/rules_rust/pull/2116#3843
Closed
walter-zeromatter wants to merge 3 commits intobazelbuild:mainfrom
Closed
apply https://github.com/bazelbuild/rules_rust/pull/2116#3843walter-zeromatter wants to merge 3 commits intobazelbuild:mainfrom
walter-zeromatter wants to merge 3 commits intobazelbuild:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
- Use find_action_by_mnemonic for Rustdoc actions instead of assuming actions[0], since symlink actions now precede Rustdoc on Windows - Deduplicate symlink deps by using only transitive_crates (which already includes direct_crates) to avoid conflicting actions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
I think hermeticbuild@f2f5b3d is a better approach as it avoids adding extra actions to the build graph and doesn't add additional depset flattening. |
Author
|
agreed, closing this in favor of that PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm reopening this fix rebased on main to try and get it merged in since this is blocking our migration to use bazel with our codebase