Skip to content

Use root-relative path to derive the solib name#604

Closed
fmeum wants to merge 1 commit intobazelbuild:mainfrom
fmeum:28513-fix
Closed

Use root-relative path to derive the solib name#604
fmeum wants to merge 1 commit intobazelbuild:mainfrom
fmeum:28513-fix

Conversation

@fmeum
Copy link
Collaborator

@fmeum fmeum commented Feb 11, 2026

short_path is not the proper analogue of Bazel's Artifact#getRootRelativePath, root_relative_path is.

Work towards bazelbuild/bazel#28135

`short_path` is not the proper analogue of Bazel's `Artifact#getRootRelativePath`, `root_relative_path` is.
@wade-arista
Copy link

@iancha1992
Copy link
Member

@trybka @pzembrod @c-mita @hvadehra Could you please take a look at this one? Our 9.0.1 release depends on this. Thank you!

@trybka
Copy link
Collaborator

trybka commented Feb 13, 2026

Given this surprising behavior, would it be possible to get a test for this?

@fmeum
Copy link
Collaborator Author

fmeum commented Feb 14, 2026

I'm not entirely sure what that would look like, to be honest. We could add an integration test against Bazel to verify that the two paths agree, but that would either require the integration test setup to be in rules_cc or we would have to add a test in Bazel after this PR has been merged and Azek has updated to it.

I'm open to other ways of testing this of course.

@iancha1992
Copy link
Member

iancha1992 commented Feb 17, 2026

@trybka @fmeum @hvadehra @c-mita @pzembrod What's the ETA on this? We're trying to see whether we should include the fix for bazelbuild/bazel#28513 in 9.0.1 or include it in the future 9.0.2 or even 9.1.0 if it takes too long.

cc: @Wyverald @meteorcloudy

@trybka
Copy link
Collaborator

trybka commented Feb 17, 2026

I'm not entirely sure what that would look like, to be honest. We could add an integration test against Bazel to verify that the two paths agree, but that would either require the integration test setup to be in rules_cc or we would have to add a test in Bazel after this PR has been merged and Azek has updated to it.

I'm open to other ways of testing this of course.

Sorry, what is Azek in this context? I'm OK with adding a test to bazel after the fact if you're willing.

Copy link
Collaborator

@trybka trybka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. @fmeum (or someone) to follow-up with a test in Bazel(?) or possibly rules_cc after some of the integration test infra is moved over.

@fmeum fmeum deleted the 28513-fix branch February 20, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants