Use root-relative path to derive the solib name#604
Use root-relative path to derive the solib name#604fmeum wants to merge 1 commit intobazelbuild:mainfrom
Conversation
`short_path` is not the proper analogue of Bazel's `Artifact#getRootRelativePath`, `root_relative_path` is.
|
FWIW I confirmed the fix with my min repro from bazelbuild/bazel#28513: https://github.com/wade-arista/bazel-demo/actions/runs/21924653638/job/63313917476#step:5:31 |
|
Given this surprising behavior, would it be possible to get a test for this? |
|
I'm not entirely sure what that would look like, to be honest. We could add an integration test against Bazel to verify that the two paths agree, but that would either require the integration test setup to be in rules_cc or we would have to add a test in Bazel after this PR has been merged and Azek has updated to it. I'm open to other ways of testing this of course. |
Sorry, what is Azek in this context? I'm OK with adding a test to bazel after the fact if you're willing. |
short_pathis not the proper analogue of Bazel'sArtifact#getRootRelativePath,root_relative_pathis.Work towards bazelbuild/bazel#28135