Open
Conversation
Adds protobuf library link tests that cover bazelbuild#584 and protocolbuffers/protobuf#25577.
armandomontanez
requested review from
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
Collaborator
Author
|
Need to exclude from versions of Bazel where this is broken, and then track with a TODO. |
Member
|
we haven't established a pattern for that in tests yet but a ton of my open prs need that too. i started using bazel_features to check 9.0. i believe that won't work in google. we might want to add a private attr on cc_common we can check for instead. |
armandomontanez
added
type: bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds protobuf library link tests that cover #584 and protocolbuffers/protobuf#25577.