Open
Conversation
Previously this function was interned using the location, not including the contents. This meant if you were iterating on the contents while developing a ruleset, the values required a bazel server restart to be reflected.
github-actions
bot
added
team-Configurability
fmeum
reviewed
Apr 13, 2026
| } | ||
| return Objects.equal(fn, that.fn) | ||
| // Use identity comparison for fn to avoid interning stale callbacks across builds. | ||
| // StarlarkFunction.equals() is based on GlobalSymbol identity (label + name), which |
Collaborator
There was a problem hiding this comment.
That's a pretty bad gotcha. I wouldn't be surprised if this caused issues elsewhere, e.g. in Args.
@brandjon @tetromino Would it make sense to allow Starlark equality to go through a different method then equals to avoid this class of bugs?
Member
Author
There was a problem hiding this comment.
i didn't dig to why this isn't being hit elsewhere, but I assume it must be unique to this somehow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this function was interned using the location, not including
the contents. This meant if you were iterating on the contents while
developing a ruleset, the values required a bazel server restart to be
reflected.